You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should reject all pending confirmations when the notification window is closed.
We already consider closing the notification window to be a rejection of the confirmation currently being shown. However if the user has multiple pending confirmations, closing the notification window only rejects the first one. This can be confusing the next time the user triggers a new confirmation, because they end up getting presented with the old one instead. This can also be confusing when the user closes the notification window on the lock screen, which currently leaves any confirmations pending without rejecting anything.
Rejecting all pending confirmations upon closing the notification window would further cement the idea that closing the window is a rejection, and it would help prevent the build-up of stale confirmations that are no longer of interest to the user.
The text was updated successfully, but these errors were encountered:
This is turning into a huge show-stopper for us. We are trying to migrate from web3 and this has us blocked.
Is there something we can do in the interim (other than having a bunch of novice users load the obsolete-metamask fix)?
function connect() {
ethereum
.request({ method: 'eth_requestAccounts' })
.then(handleAccountsChanged)
.catch((err) => {
if (err.code === 4001) {
// EIP-1193 userRejectedRequest error
// If this happens, the user rejected the connection request.
console.log('Please connect to MetaMask.');
} else {
console.error(err);
}
});
}
We should reject all pending confirmations when the notification window is closed.
We already consider closing the notification window to be a rejection of the confirmation currently being shown. However if the user has multiple pending confirmations, closing the notification window only rejects the first one. This can be confusing the next time the user triggers a new confirmation, because they end up getting presented with the old one instead. This can also be confusing when the user closes the notification window on the lock screen, which currently leaves any confirmations pending without rejecting anything.
Rejecting all pending confirmations upon closing the notification window would further cement the idea that closing the window is a rejection, and it would help prevent the build-up of stale confirmations that are no longer of interest to the user.
The text was updated successfully, but these errors were encountered: