Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Improve unit test coverage #127

Open
Gudahtt opened this issue Jan 24, 2022 · 3 comments · Fixed by #140
Open

Improve unit test coverage #127

Gudahtt opened this issue Jan 24, 2022 · 3 comments · Fixed by #140
Assignees
Labels
type-enhancement New feature or request

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Jan 24, 2022

We should strive for 100% unit test coverage, and to cover all input boundary conditions.

@Gudahtt Gudahtt added the type-enhancement New feature or request label Jan 24, 2022
@jpuri jpuri self-assigned this Feb 16, 2022
@adonesky1
Copy link
Contributor

adonesky1 commented Apr 4, 2022

Current coverage status:
Screen Shot 2022-04-04 at 12 17 25 PM

@jpuri has an open PR that adds coverage for the controllers repo side instantiation and use of this class. But perhaps we should increase the coverage within this repo? cc @Gudahtt

@Gudahtt
Copy link
Member Author

Gudahtt commented Dec 12, 2022

Reopening this as coverage is not yet at 100%

@Gudahtt Gudahtt reopened this Dec 12, 2022
@gantunesr
Copy link
Member

After the TS refactor the current code coverage is,

----------------------|---------|----------|---------|---------|----------------------------------------------------------------------------------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                            
----------------------|---------|----------|---------|---------|----------------------------------------------------------------------------------------------
All files             |   90.43 |    68.67 |   92.59 |    90.2 |                                                                                              
 KeyringController.ts |    89.3 |    67.09 |   95.83 |   89.18 | 285,305,391-397,421,449,473,493-499,522,542,562,601,606,678,761,819,825,863,891,906,939,1034 
 constants.ts         |     100 |      100 |     100 |     100 |                                                                                              
 index.ts             |     100 |      100 |      50 |     100 |                                                                                              
----------------------|---------|----------|---------|---------|----------------------------------------------------------------------------------------------

The code coverage needs to be increased to a 100% and to keep it at that level it's also needed to enable jest-it-up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type-enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants