Campaign Option>Tech Limits>Use ammo by type (unofficial) does not seem to work

[plutonick]

Campaign Options > Tech Limits > Use ammo by type (unofficial), ie being able to load an LRM 5 with LRM20 ammo, is not working.

Environment

47.5 has been tested and it's not working. It's not working on 46.0 either

Description

[Windchild292]

Test campaign from #1558.
Test30670103.cpnx.zip

This is the same as #1558, and I'm closing #1558 as this one has more information.

[ChaoticInsanity]

I am not sure the best way to fix this but it appears that the problem is AmmoType::equals only considers ammo equal if the type and rack size match. The methods leading to the check are correctly using the 'Use ammo by type' campaign option but the different rack sizes are never considered equal so the ammo from a different rack is not acceptable.

This failure happens when AmmoBin::getAmountAvailable calls Campaign::findSparePart where the predicate uses thisType.equals(((AmmoStorage)part).getType()).

Maybe a new special comparison method could be created and used in the predicate to compare the ammo type without the rack size.

[ChaoticInsanity]

Updated test campaign the covers missile racks and autocannons.
Test_ACammo.cpnx.zip