Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some test suites in constant-flow testing with Valgrind #6661

Open
gilles-peskine-arm opened this issue Nov 25, 2022 · 0 comments
Open
Labels
component-test Test framework and CI scripts enhancement

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Nov 25, 2022

Running tests under a constant flow checker is only useful if the tests have annotations to declare some data as secret. Most test suites have no such annotations, so running them under a constant flow checker is a waste of time.

This is an issue with Valgrind because it's very slow. In particular, test_valgrind_constant_flow_psa tends to time out when the CI is being slow.

The goal of this issue is, in test_valgrind_constant_flow and test_valgrind_constant_flow_psa, to only run the test suites that are useful. Currently this is the ones that contain TEST_CF_SECRET (there are no auxiliary functions in tests/src that declare things as secret).

An optional bonus would be to reduce the duplication between test_valgrind_constant_flow and test_valgrind_constant_flow_psa. They only differ in whether MBEDTLS_USE_PSA_CRYPTO is enabled, and that only influences ssl_cf_hmac in (currently) test_suite_ssl. So as a bonus, one of the components should only run that one function.

We also do constant-flow testing with MSan, but that's considerably faster so I don't think we need such hacks there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Test framework and CI scripts enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant