Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/session-and-misc post review issues. #228

Closed
2 of 4 tasks
tegefaulkes opened this issue Aug 18, 2021 · 0 comments
Closed
2 of 4 tasks

fix/session-and-misc post review issues. #228

tegefaulkes opened this issue Aug 18, 2021 · 0 comments
Assignees
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Aug 18, 2021

Specification

Some issues need to be addressed after merging fix/session-and-misc

Bin command file names need to be renamed to a standard form.
For example:

commandAgentLock.ts
commandPingNode.ts
  • We already categorize them by directories
  • There's a common command prefix being used

Let's simplify this. For example:

.
├── agent
│   ├── commandAgentLockAll.ts
│   ├── commandAgentLock.ts
│   ├── commandAgentUnlock.ts
│   ├── commandStartAgent.ts
│   ├── commandStatusAgent.ts
│   ├── commandStopAgent.ts
│   └── index.ts

Can instead be:

.
├── agent
│   ├── lockAll.ts
│   ├── lock.ts
│   ├── unlock.ts
│   ├── start.ts
│   ├── status.ts
│   ├── stop.ts
│   └── index.ts

The sub issues in the task list also need to be completed.

Additional context

Relates to #200
Relates to #218

An MR has been created for this issue.
https://gitlab.com/MatrixAI/Engineering/Polykey/js-polykey/-/merge_requests/210

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

3 participants