Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker up script fails if parent folder is not named "marquez" #2382

Closed
rossturk opened this issue Jan 26, 2023 · 2 comments · Fixed by #2943
Closed

Docker up script fails if parent folder is not named "marquez" #2382

rossturk opened this issue Jan 26, 2023 · 2 comments · Fixed by #2943
Milestone

Comments

@rossturk
Copy link
Collaborator

To save typing, I check out the Marquez repo into a folder called mqz:

git clone git@github.com:marquezproject/marquez.git mqz

I noticed that on the systems where I do this, I can't get the docker/up.sh script to complete successfully. If I check it out into a folder called marquez, it works.

Here's a video where I reproduce this issue:

git-folder-mqz.mov
@rossturk rossturk changed the title Docker up script breaks if local repo isn't named "marquez" Docker up script seems to break if local repo isn't in a folder named "marquez" Jan 26, 2023
@rossturk rossturk changed the title Docker up script seems to break if local repo isn't in a folder named "marquez" Docker up script fails if parent folder is not named "marquez" Jan 26, 2023
@seanmullane
Copy link

Can confirm this is still an ongoing issue

@wslulciuc
Copy link
Member

wslulciuc commented Oct 23, 2024

In docker/up.sh, we change to the project root directory with:

# Change working directory to project root
project_root=$(git rev-parse --show-toplevel)
cd "${project_root}/"

When we run $(git rev-parse --show-toplevel) locally for the project root, I see:

/Users/wsl/dev/io.marquezproject/mqz

This issue is that we hardcode the docker volume prefix to marquez in stead of using the base directly of project_root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants