From ef2de7b43d22d27bd3e50f04554585932b818ca0 Mon Sep 17 00:00:00 2001 From: sharpd Date: Wed, 17 Apr 2024 11:02:28 +1200 Subject: [PATCH] change tag deletion updated based on feedback Signed-off-by: sharpd --- web/src/components/datasets/DatasetTags.tsx | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/web/src/components/datasets/DatasetTags.tsx b/web/src/components/datasets/DatasetTags.tsx index 62bcfecbed..0863451136 100644 --- a/web/src/components/datasets/DatasetTags.tsx +++ b/web/src/components/datasets/DatasetTags.tsx @@ -116,13 +116,9 @@ const DatasetTags: React.FC = (props) => { } const handleDelete = (deletedTag: string) => { - const index = selectedTags.indexOf(deletedTag) - - if (index !== -1) { - const newSelectedTags = [...selectedTags] - newSelectedTags.splice(index, 1) - setSelectedTags(newSelectedTags) - } + const newSelectedTags = selectedTags.filter((tag) => deletedTag !== tag) + + setSelectedTags(newSelectedTags) datasetField ? deleteDatasetFieldTag(namespace, datasetName, deletedTag, datasetField)