Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reproducible Builds fail #490

Open
4 of 5 tasks
IzzySoft opened this issue Feb 2, 2025 · 2 comments
Open
4 of 5 tasks

[Bug]: Reproducible Builds fail #490

IzzySoft opened this issue Feb 2, 2025 · 2 comments
Labels
B: inconsistent behavior bug Something isn't working

Comments

@IzzySoft
Copy link

IzzySoft commented Feb 2, 2025

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

With the last 2 versions, reproducible builds of your app fail: the APK at your releases contains a file that's not included if we build the APK from the corresponding tag:

  -rw-r--r--  0.0 unx  1326364 b-   637941 defN 1981-01-01 01:01:02 456a5028 classes.dex
- -rw-r--r--  0.0 unx     5338 b-     2199 defN 1981-01-01 01:01:02 86f66ad5 assets/botGuardScript.js
  -rw-r--r--  0.0 unx   171676 b-    90398 defN 1981-01-01 01:01:02 d5989cee assets/fonts/Roboto-Regular.ttf

Expected Behavior

Both APKs are identical, and above mentioned file either exists in both or in none of the two

Issue Labels

inconsistent behavior

FreeTube Version

0.23.1.11

Operating System Version

n/a

Installation Method

.apk

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

For some background on reproducible builds (and this issue), see e.g. Reproducible Builds, special client support and more at IzzyOnDroid.

Nightly Build

@IzzySoft IzzySoft added the bug Something isn't working label Feb 2, 2025
@MarmadileManteater
Copy link
Owner

yeah, its bc i wasn't being mindful and i added an extra step to the build process. i should probably just trigger the new step when calling the existing command. sorry 🙇‍♀️

@IzzySoft
Copy link
Author

IzzySoft commented Feb 3, 2025

💩 happens to the best of us! 🤞 for the next release then, which hopefully has that fixed. It's the only item making RB fail, so hopefully not too difficult to fix 😉 Thanks in advance!

PS: we can also update the recipe here with the additional step if that makes it easier. Current build recipe here is:

build:
  - wget -q -O /tmp/nodejs-lts.zip -- https://nodejs.org/dist/v22.13.1/node-v22.13.1-linux-x64.tar.xz
  - sha256sum -c <<< '0d2a5af33c7deab5555c8309cd3f373446fe1526c1b95833935ab3f019733b3b  /tmp/nodejs-lts.zip'
  - tar xf /tmp/nodejs-lts.zip -C /opt
  - export PATH="${PATH}:/opt/node-v22.13.1-linux-x64/bin:${HOME}/.node/bin"
  - npm config set prefix "${HOME}/.node"
  - npm install -g yarn
  - sed -r '/version/ { s/"[0-9.]+"/"'"${APP_TAG}"'"/ }' -i package.json
  - yarn ci
  - yarn pack:android
  - cd android
  - sed -r '/release \{/,/}/ { /signingConfig/d }' -i app/build.gradle.kts
  - sed -r 's/"FreeTube Android"/"FreeTube"/' -i settings.gradle.kts
  - sed -r 's/FreeTube Android/FreeTube/' -i app/src/main/res/values/strings.xml
  - chmod +x gradlew
  - ./gradlew assembleRelease
  - mv app/build/outputs/apk/release/app-release-unsigned.apk /outputs/unsigned.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: inconsistent behavior bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants