[BUG] Using up and down buttons does not work

[jonathanmlang]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I defined BTN_UP and BTN_DOWN in pin_.h
I may have done it wrong but there is no documentation covering this.

Bug Timeline

Not sure

Expected behavior

Expected pressing the up and down buttons I assigned, to navigate the menu.

Actual behavior

Nothing happens

Steps to Reproduce

I defined BTN_UP and BTN_DOWN in pins_.h or in my case the pins_CREALITY_V4.h

Version of Marlin Firmware

02010201

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration files are unmodified from stock creality ender 3 board 4.2.2 in configurations repository

[thisiskeithb]

This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

• Marlin Documentation hosted on MarlinFW.org
• Marlin Forum hosted on RepRap.org
• Marlin Firmware Facebook Group
• Marlin Firmware for 3D Printers Facebook Group
• Marlin Configuration on YouTube
• Marlin Firmware Discord server

After seeking help from the community, if the consensus points to a bug in Marlin, then you should post a bug report.

[jonathanmlang]

These suggestions did not work.
Marlin documentation does not specify a solution.
Marlin forum returned no useful results

Therefore I can only assume this functionality isn't available to ive changed it to a Feature Request.

[thisiskeithb]

Therefore I can only assume this functionality isn't available

Buttons already work. Our Discord server is probably the best place to receive technical support, so please join!

[jonathanmlang]

I was ignored on the discord server.
Im still having difficulty with getting the up/down buttons to work. Ive added BTN_UP and BTN_DOWN to the pins file and its still not working. Went into the buttons.h file and changed SET_INPUT(BTN_UP); to SET_INPUT_PULLUP(BTN_UP);, declared HAS_ENCODER_ACTION in the pins file to enable the button related function at line 1326 of marlinui.cpp. Now I get a pullup at the button pins but they still do nothing.
This indicates to me this is actually a BUG and this issue needs reopening. Thanks

[jonathanmlang]

Ok I have solved the problem. the issue was:
Line 525 in Conditionals_LCD.h

#if IS_ULTIPANEL && DISABLED(NO_LCD_MENUS)

needs changing to:

#if ((IS_ULTIPANEL || IS_NEWPANEL) && DISABLED(NO_LCD_MENUS))

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.