Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PASSWORD_FEATURE has wrong communication handling #20301

Closed
repetier opened this issue Nov 27, 2020 · 2 comments
Closed

[BUG] PASSWORD_FEATURE has wrong communication handling #20301

repetier opened this issue Nov 27, 2020 · 2 comments

Comments

@repetier
Copy link

Bug Description

When firmware is locked with M510 send commands are not responded to with "ok", only an info message appears.

Configuration Files

Any config with
#define PASSWORD_FEATURE
enabled.

Steps to Reproduce

M510
M114

Expected behavior:

Message and a new line with "ok" so hosts are at least able to send new commands.

Actual behavior:

Only a message explaining that firmware is locked.

Additional Information

Hosts wait for "ok" or will eventually create a timeout when a send command causes no response. Since the commands are parsed and line numbers are incremented correctly, it must also send "ok" so firmware would be able to send M511 P and not be in blocked state.

@rhapsodyv
Copy link
Member

I'm closing this, as the fix was merged. Thanks!

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants