Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitenav appears above the topnav dropdowns #802

Closed
damithc opened this issue Apr 1, 2019 · 6 comments · Fixed by MarkBind/vue-strap#103
Closed

sitenav appears above the topnav dropdowns #802

damithc opened this issue Apr 1, 2019 · 6 comments · Fixed by MarkBind/vue-strap#103
Labels
c.Bug 🐛 f-TopNav p.Critical Need a hot patch urgently, cannot wait for next release

Comments

@damithc
Copy link
Contributor

damithc commented Apr 1, 2019

v2.0.0

image

@Chng-Zhi-Xuan
Copy link
Contributor

Chng-Zhi-Xuan commented Apr 1, 2019

A fix was done for Typeahead (search bar). Looks like this has to be done as well.

Details of the fix in the commit message here

@damithc
Copy link
Contributor Author

damithc commented Apr 1, 2019

Just realized that items are not clickable either. As such, a fix is needed pronto.

@damithc damithc added p.Critical Need a hot patch urgently, cannot wait for next release and removed p.Medium labels Apr 1, 2019
@marvinchin
Copy link
Contributor

marvinchin commented Apr 1, 2019

I've made a PR (MarkBind/vue-strap#103) that uses the same fix as MarkBind/vue-strap@9a4a075.

However, MarkBind/vue-strap#102 has been merged to vue-strap, but the corresponding PR in markbind #797 has not been merged. This causes our current navbar styles to break (they all turn blue) when using the bundle built on top of vue-strap master.

Screenshot 2019-04-01 at 8 02 42 PM

I'm thinking we either need to:

What do you guys think about this?

cc: @yamgent @luyangkenneth

@luyangkenneth
Copy link
Contributor

I think #797 is ready to be merged (pending action from anyone with merge privileges). Seems to me that it's the most straightforward way to unblock this fix.

@yamgent
Copy link
Member

yamgent commented Apr 1, 2019

Double checked, MarkBind/vue-strap#103 fixed the issue. Since this is a critical bug, will make a new release soon.

@damithc
Copy link
Contributor Author

damithc commented Apr 2, 2019

Working. Thanks for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug 🐛 f-TopNav p.Critical Need a hot patch urgently, cannot wait for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants