Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom boxes #69

Closed
damithc opened this issue May 20, 2017 · 2 comments · Fixed by MarkBind/vue-strap#26
Closed

Support custom boxes #69

damithc opened this issue May 20, 2017 · 2 comments · Fixed by MarkBind/vue-strap#26
Assignees
Labels
Milestone

Comments

@damithc
Copy link
Contributor

damithc commented May 20, 2017

It's good if we create custom boxes (similar to current tip boxes) with a combination of color and icon.

<box color="#42b0f4" icon=":rocket:">
    text
</box>
@damithc damithc added the p.Low label May 20, 2017
@damithc damithc changed the title Support custom tip boxes Support custom boxes May 20, 2017
@yamgent yamgent self-assigned this May 18, 2018
@yamgent
Copy link
Member

yamgent commented May 18, 2018

One possible improvement to the original idea, is to add color and icon attributes to the existing tip-box component instead of creating a new box component.

This allows the user to inherit existing styles (e.g. the user may want to use the info tip-box, but still wants to override the icon with rocket)

<tip-box type="info" icon=":rocket:">
    info but with rocket icon
</tip-box>

@damithc would that be good?

@damithc
Copy link
Contributor Author

damithc commented May 18, 2018

Yes, that works.
I'm in favor of using box instead of tip-box though: shorter and more generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants