Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iconify pageNav when there is no space #616

Closed
damithc opened this issue Jan 22, 2019 · 4 comments
Closed

Iconify pageNav when there is no space #616

damithc opened this issue Jan 22, 2019 · 4 comments

Comments

@damithc
Copy link
Contributor

damithc commented Jan 22, 2019

v1.17.0

Current: PageNav disappears when the page width is below a certain size

Suggested: Give some other way to access it if there is not enough space to show it. e.g., an iconified view that the user can click to expand?

@Chng-Zhi-Xuan
Copy link
Contributor

Chng-Zhi-Xuan commented Jan 22, 2019

Implementation wise, we can mirror the implementation of site-nav. However having 2 expandable bars (left and right) might take too much precious space (for mobile devices). But, less time is required to implement this.

A more integrated approach is having a second menu button appear below the site-nav menu button.

This will take more time to implement since:

  • Need to ensure compatibility with existing site-nav code
  • Account for all the different cases (site-nav still visible, page-nav collapsed) or (both site-nav and page-nav collapsed) etc.

Which do you prefer?

@damithc
Copy link
Contributor Author

damithc commented Jan 22, 2019

I prefer the first one. Perhaps we can find a way to prevent the iconified versions taking space? e.g., use a floating square (instead of a vertical column) with some transparency so that it doesn't take any extra space at all?

@Chng-Zhi-Xuan
Copy link
Contributor

Chng-Zhi-Xuan commented Jan 22, 2019

Yes it is possible to have a floating translucent button. We can refine the position and design once a working prototype is up (either from me or the CS3282 team) 😃

@ang-zeyu
Copy link
Contributor

closing as a possible specific solution to #980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants