Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footers: omit footer tags for non-inline footers #251

Closed
damithc opened this issue Jun 4, 2018 · 5 comments
Closed

Footers: omit footer tags for non-inline footers #251

damithc opened this issue Jun 4, 2018 · 5 comments
Labels
a-AuthorUsability c.Enhancement d.easy p.Low

Comments

@damithc
Copy link
Contributor

damithc commented Jun 4, 2018

v1.8.0

As a file in the footers directory is already known to be a footer, we can omit the <footer> tag from them?
@Chng-Zhi-Xuan
Copy link
Contributor

Chng-Zhi-Xuan commented Jun 4, 2018 •
edited
Loading

Yes, we can actually wrap the footer tag for the user while processing the .md file. Would minimize some clutter 👍

@Chng-Zhi-Xuan Chng-Zhi-Xuan self-assigned this Jun 4, 2018
@acjh
Copy link
Contributor

acjh commented Jun 4, 2018

User may want to specify CSS classes or styles on footer element. This doesn't seem worthwhile.

@damithc
Copy link
Contributor Author

damithc commented Jun 4, 2018

User may want to specify CSS classes or styles on footer element.

That true. Can make it optional.

This doesn't seem worthwhile.

Yes, not worth spending time now. This is an AuthorUsability issue. Can leave for a version in the distant future. Same for other AuthorUsability issues, unless high priority.

@damithc
Copy link
Contributor Author

damithc commented Jun 4, 2018

In fact, a site is unlikely to have more than one footer. This is a VERY low value enhancement.

@ang-zeyu ang-zeyu added the d.easy label Jun 9, 2020
@ang-zeyu
Copy link
Contributor

ang-zeyu commented Jan 15, 2021 •
edited
Loading

Done Irrelevant with the new layout system #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-AuthorUsability c.Enhancement d.easy p.Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@damithc @ang-zeyu @acjh @Chng-Zhi-Xuan