Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to improve the efficiency of markbind with parallelism #2503

Open
yiwen101 opened this issue Apr 6, 2024 · 1 comment
Open

Refactor to improve the efficiency of markbind with parallelism #2503

yiwen101 opened this issue Apr 6, 2024 · 1 comment

Comments

@yiwen101
Copy link
Contributor

yiwen101 commented Apr 6, 2024

Some of the current code can benefit from parallelism. Eg:

Screenshot 2024-04-06 at 10 28 35

Another issue of this way of writing is, we do not have a clear idea on the dependency of the sequence of run.

In future, we should run every no conflicting async function in parallel, and shift to A.then().then() style to specify sequential dependencies.

@kaixin-hc kaixin-hc changed the title Refractor to improve the efficiency of markbind with parallelism Refactor to improve the efficiency of markbind with parallelism Apr 7, 2024
@tlylt
Copy link
Contributor

tlylt commented Jul 23, 2024

PRs that address this issue should be careful with the potential unintended impacts on functionality. I believe some functions have (undesirable) implicit dependencies and introducing concurrent execution could lead to subtle bugs. The prereq for tackling this is therefore to come up with a clear flow diagram describing the various operations.

Since this is about performance, another thing to ensure is to capture the before and after timing, as well as CPU/memory consumption to assess the impact.

@tlylt tlylt added d.moderate and removed d.easy labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants