You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
kaixin-hc
changed the title
Refractor to improve the efficiency of markbind with parallelism
Refactor to improve the efficiency of markbind with parallelism
Apr 7, 2024
PRs that address this issue should be careful with the potential unintended impacts on functionality. I believe some functions have (undesirable) implicit dependencies and introducing concurrent execution could lead to subtle bugs. The prereq for tackling this is therefore to come up with a clear flow diagram describing the various operations.
Since this is about performance, another thing to ensure is to capture the before and after timing, as well as CPU/memory consumption to assess the impact.
Some of the current code can benefit from parallelism. Eg:
Another issue of this way of writing is, we do not have a clear idea on the dependency of the sequence of run.
In future, we should run every no conflicting async function in parallel, and shift to A.then().then() style to specify sequential dependencies.
The text was updated successfully, but these errors were encountered: