Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand functional test extensions and check for whitespace #1131

Closed
ang-zeyu opened this issue Mar 17, 2020 · 0 comments · Fixed by #1156
Closed

Expand functional test extensions and check for whitespace #1131

ang-zeyu opened this issue Mar 17, 2020 · 0 comments · Fixed by #1156

Comments

@ang-zeyu
Copy link
Contributor

Is your request related to a problem?

  1. Our current testutils for functional tests aren't comparing diffs for anything other than .html files and siteData.json.
  2. The diff also ignores whitespace, which should not be the case as it can be an indicator of subtle, unintended changes.

Describe the solution you'd like

Expand the diffing to all text files, followed with an appropriate blacklist ( e.g. for .log files ).
We can use something like https://www.npmjs.com/package/istextorbinary for the first part of this check.

Describe alternatives you've considered

Manually add extensions ( e.g. .css, .js )

  • Problem: We would need to add extensions to account for all these cases as more types are encountered ( e.g. future plugin file extensions )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant