You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our current testutils for functional tests aren't comparing diffs for anything other than .html files and siteData.json.
The diff also ignores whitespace, which should not be the case as it can be an indicator of subtle, unintended changes.
Describe the solution you'd like
Expand the diffing to all text files, followed with an appropriate blacklist ( e.g. for .log files ).
We can use something like https://www.npmjs.com/package/istextorbinary for the first part of this check.
Describe alternatives you've considered
Manually add extensions ( e.g. .css, .js )
Problem: We would need to add extensions to account for all these cases as more types are encountered ( e.g. future plugin file extensions )
The text was updated successfully, but these errors were encountered:
Is your request related to a problem?
.html
files andsiteData.json
.Describe the solution you'd like
Expand the diffing to all text files, followed with an appropriate blacklist ( e.g. for
.log
files ).We can use something like https://www.npmjs.com/package/istextorbinary for the first part of this check.
Describe alternatives you've considered
Manually add extensions ( e.g.
.css
,.js
)The text was updated successfully, but these errors were encountered: