-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong implementation of "SinusoidalCenter" #863
Comments
Makuna
added
the
investigating
Currently under investigation for more understanding of the problem.
label
Nov 29, 2024
Its currently implemented as
In my spread sheet test, it is implemented as
You can see the translation from spread sheet to c++ the extra () causes the issue. So, it should be
|
Makuna
added
bug
and removed
investigating
Currently under investigation for more understanding of the problem.
labels
Dec 3, 2024
Merged
Makuna
added
the
pending
Pending new release; already merged but not released in a version
label
Dec 3, 2024
Thank you for your quick response and fixing! |
I leave issues open and labeled "pending" until I make a release with the changes in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There is an error in the function implementation of "SinusoidalCenter" that caused the output to be abnormal when the input was greater than 0.5
To Reproduce
Steps to reproduce the behavior:
In the file "src/internal/animations/NeoEase.h", line 214. In the function "SinusoidalCenter", I think there is an extra parenthesis in the
code "return (-0.5f * (cos(PI * (unitValue-0.5f)) + 1.0f));", I think the correct one is "return (-0.5f * cos(PI * (unitValue - 0.5f)) + 1.0f);"
Expected behavior
I think the correct one is "return (-0.5f * cos(PI * (unitValue - 0.5f)) + 1.0f);", according to the picture "sinusoidal.png"
Development environment (please complete the following information):
The text was updated successfully, but these errors were encountered: