-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update third party JSON. #35
Comments
Hi, thank you for posting this issue. The only header exposed is the forward header json_fwd.hpp that only declares the json structures but does not define anything. Looking at the nw json hpp release, it says it is retro compatible. Are you somehow impacted by the older version included in LDtkLoader source ? How is it breaking the compatibility ? |
Thank you for the logs. Indeed, in the version 3.11.3, they introduced an additional template parameter for the json_base template, as you can see in this commit. They say it does not break compatibility, but it seems it did break in your case. I'll update the version of the json lib in LDtkLoader, that should fix your issue. |
I updated the json files to latest version: f3a9f03 The latest LDtkLoader 1.5.3 release should work well with your projects now. |
Thank you very much! |
nlohmann json recently got updated to 3.11.3, breaking compat with this library due to outdated included header.
Suggest either removing header or updating.
The text was updated successfully, but these errors were encountered: