Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third party JSON. #35

Closed
reworks-org opened this issue Nov 30, 2023 · 5 comments
Closed

Update third party JSON. #35

reworks-org opened this issue Nov 30, 2023 · 5 comments

Comments

@reworks-org
Copy link

nlohmann json recently got updated to 3.11.3, breaking compat with this library due to outdated included header.

Suggest either removing header or updating.

@Madour
Copy link
Owner

Madour commented Nov 30, 2023

Hi, thank you for posting this issue.
The json.hpp header is in the src folder and is not installed along side the library include files.
This should allow users of the library to use their own version of nlohmann json in their project.

The only header exposed is the forward header json_fwd.hpp that only declares the json structures but does not define anything. Looking at the nw json hpp release, it says it is retro compatible.

Are you somehow impacted by the older version included in LDtkLoader source ? How is it breaking the compatibility ?

@Ryu204
Copy link

Ryu204 commented Feb 15, 2024

Hi, thank you for your library. In my project I think the json_fwd.hpp is causing a problem with template definitions, but I am not sure how. I can provide the build log here.

I am using LdtkLoader version 1.5.2 and json latest's master.

@Madour
Copy link
Owner

Madour commented Feb 15, 2024

Thank you for the logs. Indeed, in the version 3.11.3, they introduced an additional template parameter for the json_base template, as you can see in this commit.

They say it does not break compatibility, but it seems it did break in your case.

I'll update the version of the json lib in LDtkLoader, that should fix your issue.

@Madour
Copy link
Owner

Madour commented Feb 15, 2024

I updated the json files to latest version: f3a9f03

The latest LDtkLoader 1.5.3 release should work well with your projects now.

@Madour Madour closed this as completed Feb 15, 2024
@Ryu204
Copy link

Ryu204 commented Feb 16, 2024

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants