-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate this project into psutil release workflow #1
Comments
For the projects I am involved in, I really want to run the tests on the installed wheels, to catch problems like the ones we hit here. Just for example, this setup runs tests on 32-bit Linux, which is somewhat difficult to as part of a typical travis-ci setup. For example, Scipy just hit a set of 32-bit Linux failures, that we only found with the daily wheel tests. For the release procedure, what do you think of the procedure here : https://github.com/MacPython/cython-wheels/blob/master/README.rst#quickstart . Is that automated enough? |
OK, fine with me (tests for all combos). Also I see:
What is it? Do we need it? |
I can replicate the segfault with:
Then, inside the container:
So - I guess it must be something about the code linked in this old Linux container? |
I cannot debug this problem right now but in order to move this forward I temporarily disabled that test: |
I did this:
...and tested with Python 2.7 but can't replicate the segfault. |
...and I completely forgot how this is supposed to work. =) |
Hmm - at the end of the log it says that the key for the travis upload is missing. I'm not sure why that is. I can try resetting it again. |
See #2 |
I still see:
|
Sorry for being annoying but... any chance you can take a look at this any time soon? |
That's OK - where do you see that message? Can you point to the build? If on your repo, that's expected, if on MacPython/psutil, then not expected. |
Here at the very bottom: https://travis-ci.org/MacPython/psutil/builds/300553111 |
Strange - I can't explain that. Try this instead?
|
Same probelm. |
Sorry - my fault - see #3 |
Thanks Matthew. It now uploads wheels! |
If you are running on Linux or Mac, it shouldn't be too much trouble getting docker working on your machine. After that, if you're lucky, the segfault also occurs when building on the test image (an Ubuntu Trusty image), and you can do all the debugging there. Otherwise, you'll have to build the wheel first on the manylinux image, and then test it on the test image, as the tests are doing. For example, here's some instructions for scikit-image, in this case debugging a 32-bit error: https://github.com/scikit-image/scikit-image/wiki/Testing-in-32-bit-environment Please let me know if I can help with the machinery. Are you on Linux or MacOS? |
Thanks Matthew. |
Do these commands do the job?
That should start you up in the testing container - then you'd build and install |
Sorry - in more detail - here is me trying to replicate the error with docker containers. I make sure I'm in the First I build the wheel in the manylinux docker container:
Then I test in the test docker container (trusty):
For these, I get lots of test errors - I'm hoping you understand those better than I do ... |
Thanks for the accurate instructions. I cannot reproduce the segfault. Were you? |
I got lots of errors, but not the segfault. I was wondering whether the errors had disguised the segfault, but I didn't understand the errors well enough to fix them. |
Hello. I found this while looking for a way to use psutil without installing gcc. Were you guys successful in your efforts? |
This is the continuation of giampaolo/psutil#824
More or less, the goal should be to consolidate the workflow of this repository so that when a new psutil version is out (or we're close to it) we should be able to easily do the following:
Ideally, I would like to do this in most automated way as possible (e.g. via
make pre-release
andmake release
commands).The hypothetical
make pre-release
command should execute steps 1, 2 and 3. IMO it is not necessary that psutil tests run because they're slow, especially on OSX and we already have a travis/appveyor setup configured in the original psutil project.The hypothetical
make release
command should download the wheels from rackspace (all of them) and upload them on PYPI viatwine
. This task is already solved in the psutil project (for windows wheels).Extra: (note: still not sure) once this is done and proven to be robust enough we may probably want to also upload sources (
sdist
) from here and possibly also Windows wheels, removing those 2 responsibilities from the original psutil project.The text was updated successfully, but these errors were encountered: