Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cable flavour and has_whitening_filter to rfinput struct #64

Closed
gsleap opened this issue Nov 23, 2023 · 2 comments
Closed

Add cable flavour and has_whitening_filter to rfinput struct #64

gsleap opened this issue Nov 23, 2023 · 2 comments
Assignees
@gsleap
Labels
enhancement New feature or request

Comments

@gsleap
Copy link
Member

gsleap commented Nov 23, 2023 •
edited
Loading

From @andreww5au:

Every cable flavour starting with 'RG6', except for 'RG6_90' and 'everything starting with LMR' [has a whitening filter].
  1. We want to add another field for each rf_input which is "flavour" which is just the string that AW provides in the metafits?
  2. Add a new bool "has_whitening_filter". TRUE if ((cable_flavour starts with "RG6" AND cable_flavour != "RG6_90") OR cable_flavour starts with "LMR")
@gsleap gsleap added the enhancement New feature or request label Nov 23, 2023
@gsleap gsleap self-assigned this Nov 23, 2023
@gsleap gsleap changed the title Update receiver types and implement cable flavour Add cable flavour and has_whitening_filter to rfinput struct Nov 23, 2023
@d3v-null
Copy link
Contributor

relevant ticket in Birli MWATelescope/Birli#147

@gsleap
Copy link
Member Author

gsleap commented Nov 24, 2023

Fixed by 22547ed

@gsleap gsleap closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsleap gsleap

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d3v-null @gsleap