Bad error message on data without "common good" coarse channels

[cjordan]

i.e.

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NoCommonTimesteps { hdu_info: "{1466188255000: {1: (0, 1), 2: (0, 1), 3: (0, 1), 4: (0, 1), 5: (0, 1), 7: (0, 1), 8: (0, 1), 9: (0, 1), 10: (0, 1), 11: (0, 1), 12: (0, 1), 13: (0, 1), 14: (0, 1), 15: (0, 1), 16: (0, 1), 17: (0, 1), 18: (0, 1), 19: (0, 1), 20: (0, 1), 21: (0, 1), 22: (0, 1), 23: (0, 1), 24: (0, 1)}, 1466188256000: {6: (0, 1)}, 1466188257000:

(I assume Birli attempted to preprocess the obsid into a ms/uvfits.) This happens on obsid 1150224192 (I have the data on /astro).

Ideally, Birli shouldn't have any unwraps; all instances of unrecoverable errors should emit a human-readable error message instead. I'm happy to offer experience here as I've tried to be thorough with hyperdrive. The presence of unwrap here is ultimately responsible for the bad error message.

[d3v-null]

The recent changes we made to the error handling now mean that the error messages look like this.

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NoCommonTimesteps

These error messages used to be very helpful for diagnosis, as without this message, you need to download the raw files to see what's going on, so I'll see what I can do to make the display of this error message a little more detailed.

[cjordan]

Can you point to the code that you claim have now made error messages look this way?

[gsleap]

I'm seeing a few of these failures in ASVO recently. Do we really want the main thread panicing? Since we can catch this specific error, why not exit properly with a return code and message? (as opposed to a panic)

[cjordan]

I'm seeing a few of these failures in ASVO recently. Do we really want the main thread panicing? Since we can catch this specific error, why not exit properly with a return code and message? (as opposed to a panic)

Yep, basically all that needs to happen is:

1. Replace .unwrap with ?
2. Handle any additional errors that need to be propagated as part of 1.