-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable submeso. parameterization in global_ocean
#533
Conversation
compass/ocean/tests/global_ocean/daily_output_test/streams.forward
Outdated
Show resolved
Hide resolved
I tried to run QU240 tests with this branch but they are all failing with state validation errors, perhaps related to the masking PR E3SM-Project/E3SM#5325 that we're trying to debug. OSX CI failures are unrelated to this. |
@xylar I had in mind that we would add an additional test with submesoscale turned on. It could be just |
@cbegeman, we could do that, but the default in E3SM is to run with the parameterization on: |
global_ocean
global_ocean
3f82660
to
2039714
Compare
@xylar I didn't realize that. In that case, I'm fine with it being on by default. |
@xylar I've tested the nightly suite plus |
TestingI tested this on Chrysalis with Intel and OpenMPI. I ran all QU240 test cases using the branch for E3SM-Project/E3SM#5458. All tests passed with this branch, whereas 8 forward mode tests failed with the version of MPAS-Ocean in the We will need to update the submodule before this goes in. |
2039714
to
552a47c
Compare
552a47c
to
51a971f
Compare
The submodule was update to include E3SM-Project/E3SM#5458 in #558 so this can now be merged. |
Re-testingI ran the I ran all QU240 test cases (this time without a baseline) and they finished successfully. |
This merge also adds submeso output variables to
daily_output
test.Checklist
Testing
in this PR) any testing that was used to verify the changescloses #532