Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable submeso. parameterization in global_ocean #533

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 17, 2023

This merge also adds submeso output variables to daily_output test.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

closes #532

@xylar xylar requested a review from cbegeman February 17, 2023 00:55
@xylar xylar self-assigned this Feb 17, 2023
@xylar xylar added bug Something isn't working ocean labels Feb 17, 2023
@xylar
Copy link
Collaborator Author

xylar commented Feb 17, 2023

I tried to run QU240 tests with this branch but they are all failing with state validation errors, perhaps related to the masking PR E3SM-Project/E3SM#5325 that we're trying to debug.

OSX CI failures are unrelated to this.

@cbegeman
Copy link
Collaborator

@xylar I had in mind that we would add an additional test with submesoscale turned on. It could be just daily_output_submeso_test or up a level at PHC_submeso

@xylar
Copy link
Collaborator Author

xylar commented Feb 17, 2023

@cbegeman, we could do that, but the default in E3SM is to run with the parameterization on:
https://github.com/E3SM-Project/E3SM/blob/982d11520aec729ef32ee6991bd85162f26b917b/components/mpas-ocean/bld/namelist_files/namelist_defaults_mpaso.xml#L156
So it feels to me like it should be on in global_ocean, too. This is consistent with GM being on by default in global_ocean.

@xylar xylar changed the title Enable submeso. parameterization in global_ocean Enable submeso. parameterization in global_ocean Feb 17, 2023
@xylar xylar force-pushed the add_submeso_to_daily_output branch from 3f82660 to 2039714 Compare February 17, 2023 19:01
@cbegeman
Copy link
Collaborator

@xylar I didn't realize that. In that case, I'm fine with it being on by default.

@cbegeman
Copy link
Collaborator

@xylar I've tested the nightly suite plus ocean_global_ocean_QU240_PHC_daily_output_test with the bugfix branch E3SM-Project/E3SM#5458 and found that all tests pass (chrys, intel, openmpi).

@xylar
Copy link
Collaborator Author

xylar commented Feb 17, 2023

Testing

I tested this on Chrysalis with Intel and OpenMPI. I ran all QU240 test cases using the branch for E3SM-Project/E3SM#5458. All tests passed with this branch, whereas 8 forward mode tests failed with the version of MPAS-Ocean in the E3SM-Project submodule.

We will need to update the submodule before this goes in.

@xylar xylar force-pushed the add_submeso_to_daily_output branch from 552a47c to 51a971f Compare April 13, 2023 10:46
@xylar
Copy link
Collaborator Author

xylar commented Apr 13, 2023

The submodule was update to include E3SM-Project/E3SM#5458 in #558 so this can now be merged.

@xylar
Copy link
Collaborator Author

xylar commented Apr 13, 2023

Re-testing

I ran the pr test suite, comparing with the current main as a baseline and (to my surprise!) all tests passed. I verified that submesoscale is turned off for the baseline and on for this run (according to the namelist options), so it seems the tests are short enough not to detect the difference.

I ran all QU240 test cases (this time without a baseline) and they finished successfully.

@xylar xylar merged commit c485622 into MPAS-Dev:main Apr 13, 2023
@xylar xylar deleted the add_submeso_to_daily_output branch April 13, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working E3SM PR finished ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add submesoscale variables to daily_output test cases
2 participants