-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regionNames
coordinate to NetCDF output with "standard" region names
#1066
Conversation
@golaz, just a heads up that the confusing output you found for the OHC anomaly should be fixed in the new Unified, assuming I can get this reviewed and added very soon. |
fc6cdb9
to
82b6a96
Compare
TestingI rand the test suite and all tests seem to have run successfully: However, the web portal is basically unusable today so I can't see if the output looks right. |
@milenaveneziani, would you have time to look this over in the coming week? I mostly want to make sure you're conceptually okay with the changes but if you want to look through the code changes and/or the output from the test suite, feel free. Output is in:
|
Looks great @xylar: thanks for pinging me. I just noticed a couple of typos in the comments (look for 'shrot'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on code inspection.
Thanks @milenaveneziani, I'll fix those typos. |
82b6a96
to
caddb2d
Compare
Two MPAS-Ocean analysis members use ocean regions that are hard-coded and for which no coordinate array or other metadata is provided. This merge adds both
regionNames
andregionShortNames
coordinates to datasets that use these standard regions. Here, we also renamenOceanRegionsTmp
tonOceanRegions
because theTmp
suffix is confusing and needless.All analysis using the hard-coded ocean regions has been updated. The config option
regions
has been renamed toregionShortNames
for clarity, andplotTitle
has been renamed toregionNames
, since these long names are more rightly the names of the regions.This should help folks that wish to use the NetCDF output from MPAS-Analysis for their own plots.
Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changesFixes #1065