You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our functions _fit_auto_regression_xr returns the "standard deviation of the residuals". But _draw_auto_regression_correlated_np requires the (co-)variance.
This was done because the two functions were extracted in separate PRs (#161 and #161) and the original code did the same. It's a bit wasteful if we constantly convert there and back. We should change this before we release v0.9.
What I want to say fit_auto_regression should return var but the old code path will keep using std - i.e. the place of the sqrt and **2 should change. Should not be too difficult but may (should) need some code test changes.
This is a bit less trivial than I thought - in train_gv_AR we take the average over the AR params - including the standard deviation. However, this is wrong: you have to average the covariances (or even take care of the size of the samples: https://stats.stackexchange.com/q/25848)
Our functions
_fit_auto_regression_xr
returns the "standard deviation of the residuals". But_draw_auto_regression_correlated_np
requires the (co-)variance.This was done because the two functions were extracted in separate PRs (#161 and #161) and the original code did the same. It's a bit wasteful if we constantly convert there and back. We should change this before we release v0.9.
mesmer/mesmer/stats/auto_regression.py
Line 233 in acd80e4
mesmer/mesmer/stats/auto_regression.py
Lines 82 to 83 in acd80e4
mesmer/mesmer/calibrate_mesmer/train_gv.py
Line 214 in acd80e4
mesmer/mesmer/calibrate_mesmer/train_lv.py
Line 249 in acd80e4
The text was updated successfully, but these errors were encountered: