Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use linear regression functions in create_emus_lv_OLS #156

Closed
Tracked by #149
mathause opened this issue Jun 10, 2022 · 0 comments · Fixed by #240
Closed
Tracked by #149

use linear regression functions in create_emus_lv_OLS #156

mathause opened this issue Jun 10, 2022 · 0 comments · Fixed by #240
Labels
good first issue Good for newcomers
Milestone
v0.9.0

Comments

@mathause
Copy link
Member

In create_emus_OLS_each_gp_sep the linear regression prediction is made manually and looped through all gridpoints see:

mesmer/mesmer/create_emulations/create_emus_lv.py

Line 219 in 3892e76

def create_emus_lv_OLS(params_lv, preds_lv):

This could be replaced by using our LinearRegression class:

mesmer/mesmer/core/linear_regression.py

Line 9 in 3892e76

class LinearRegression:

See #155 for details.
@mathause mathause added the good first issue Good for newcomers label Jun 10, 2022
This was referenced Jun 10, 2022
Closed
Closed
@mathause mathause added this to the v0.9.0 milestone Dec 13, 2022
@mathause mathause mentioned this issue Jan 13, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

use LinearRegression.predict() mathause/mesmer
1 participant
@mathause