Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force pointer-events none to button's icon #26

Open
joniahola opened this issue Mar 3, 2022 · 1 comment
Open

Force pointer-events none to button's icon #26

joniahola opened this issue Mar 3, 2022 · 1 comment

Comments

@joniahola
Copy link

Hello.

I realised that if your website css styles not have pointer-events: none rules to button's icon navigation, you get problems: sometimes you will click to icon and sometimes to navigation item. This project doesn't handle situations where you click icon.

Proposals for fix that minor problem:

  • Write guide to README
  • Add default styles to navigation
  • Handle this exception in handleSubNav function. target.nextElementSibling is null if you click svg.
@samikeijonen
Copy link
Member

Hi @joniahola and sorry I totally have missed your issue!

We have a note about this in readme: https://github.com/MEOM/navigation#issues-opening-and-closing-the-sub-menus

At the moment CSS is up to developers even though in demos we have this CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joniahola @samikeijonen