Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: a few mutable default arguments are back #4655

Closed
tylerjereddy opened this issue Aug 15, 2024 · 3 comments · Fixed by #4834
Closed

MAINT: a few mutable default arguments are back #4655

tylerjereddy opened this issue Aug 15, 2024 · 3 comments · Fixed by #4834

Comments

@tylerjereddy
Copy link
Member

Oli dealt with this 9 years ago in gh-590, but a few cases have accumulated since then. It is fairly low priority but easy to fix.

Can check locally with i.e., ruff.toml like this:

[lint]
ignore = ["E501"]
select = ["B006", "B008"]

ruff check package

Some obscure bug happened because of this in another project so I just thought of it again.

@Plomo-02
Copy link

Plomo-02 commented Nov 4, 2024

Hello, can I be assigned to this issue?

@RMeli
Copy link
Member

RMeli commented Nov 5, 2024

@Plomo-02 we do not assign issues. Since there is no other open PR against this issue, feel free to work on it and open a PR when you are ready for review.

@tanishy7777
Copy link
Contributor

tanishy7777 commented Nov 30, 2024

I have tried to fix this issue in the above PR (#4810). Please let me know if any further changes are to be made for this issue.
@RMeli @tylerjereddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment