Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbval errors on stderr output changes #357

Closed
IAlibay opened this issue Jan 2, 2024 · 3 comments · Fixed by #358
Closed

nbval errors on stderr output changes #357

IAlibay opened this issue Jan 2, 2024 · 3 comments · Fixed by #358

Comments

@IAlibay
Copy link
Member

IAlibay commented Jan 2, 2024

See: #356

FAILED polymer.ipynb::Cell 1
FAILED clustering_ensemble_similarity.ipynb::Cell 3
FAILED clustering_ensemble_similarity.ipynb::Cell 11
FAILED clustering_ensemble_similarity.ipynb::Cell 15
FAILED clustering_ensemble_similarity.ipynb::Cell 18
FAILED convergence.ipynb::Cell 2
FAILED convergence.ipynb::Cell 8
FAILED dimension_reduction_ensemble_similarity.ipynb::Cell 3
FAILED dimension_reduction_ensemble_similarity.ipynb::Cell 10
FAILED dimension_reduction_ensemble_similarity.ipynb::Cell 20
FAILED harmonic_ensemble_similarity.ipynb::Cell 3

@IAlibay
Copy link
Member Author

IAlibay commented Jan 2, 2024

Do we actually need to do a stderr check here? Could we just skip it completely?

@lilyminium
Copy link
Member

Makes sense to me!

@IAlibay
Copy link
Member Author

IAlibay commented Jan 2, 2024

Very quick attempt at doing this in https://github.com/MDAnalysis/UserGuide/actions/runs/7388882737/job/20100603113?pr=358 doesn't seem to work. Someone might be better suited to take over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants