From 336d63995ba302e1c7053e3004f3a7c6072eddb2 Mon Sep 17 00:00:00 2001
From: Yann Prono <yann.prono@maif.fr>
Date: Tue, 21 Jan 2025 20:28:17 +0100
Subject: [PATCH] feat: make TopicDetailComponent scrollable

---
 crates/tui/src/component/root_component.rs    |  4 +-
 .../src/component/topic_details_component.rs  | 38 +++++++++++++------
 2 files changed, 28 insertions(+), 14 deletions(-)

diff --git a/crates/tui/src/component/root_component.rs b/crates/tui/src/component/root_component.rs
index 69c365e..a33f14a 100644
--- a/crates/tui/src/component/root_component.rs
+++ b/crates/tui/src/component/root_component.rs
@@ -21,7 +21,7 @@ use super::{
     footer_component::FooterComponent, help_component::HelpComponent,
     progress_bar_component::ProgressBarComponent, record_details_component::RecordDetailsComponent,
     records_component::RecordsComponent, schemas_component::SchemasComponent,
-    search_component::SearchComponent, topic_details_component::ScrollableTopicDetailsComponent,
+    search_component::SearchComponent, topic_details_component::TopicDetailsComponent,
     topics_and_records_component::TopicsAndRecordsComponent, topics_component::TopicsComponent,
     Component, ComponentName, ConcurrentRecordsBuffer, State,
 };
@@ -53,7 +53,7 @@ impl RootComponent {
         let mut components: [Arc<Mutex<dyn Component>>; 9] = [
             Arc::new(Mutex::new(TopicsComponent::new(selected_topics))),
             Arc::new(Mutex::new(RecordsComponent::new(records))),
-            Arc::new(Mutex::new(ScrollableTopicDetailsComponent::default())),
+            Arc::new(Mutex::new(TopicDetailsComponent::default())),
             Arc::new(Mutex::new(RecordDetailsComponent::new(&state))),
             Arc::new(Mutex::new(SearchComponent::new(
                 &query,
diff --git a/crates/tui/src/component/topic_details_component.rs b/crates/tui/src/component/topic_details_component.rs
index 2b88931..3717803 100644
--- a/crates/tui/src/component/topic_details_component.rs
+++ b/crates/tui/src/component/topic_details_component.rs
@@ -1,5 +1,5 @@
 //! Component showing information regarding a given topic: partitions, consumer groups, replicas ...
-use crossterm::event::KeyEvent;
+use crossterm::event::{KeyCode, KeyEvent};
 
 use itertools::Itertools;
 use lib::{ConsumerGroupState, TopicDetail};
@@ -16,17 +16,14 @@ use tokio::sync::mpsc::UnboundedSender;
 
 use crate::{error::TuiError, Action};
 
-use super::{
-    vertical_scrollable_block::VerticalScrollableBlock, Component, ComponentName, State, WithHeight,
-};
-
-pub type ScrollableTopicDetailsComponent = VerticalScrollableBlock<TopicDetailsComponent>;
+use super::{scroll_state::ScrollState, Component, ComponentName, State, WithHeight};
 
 #[derive(Default)]
 pub struct TopicDetailsComponent {
     pub details: Vec<TopicDetail>,
     pub action_tx: Option<UnboundedSender<Action>>,
     pub state: TableState,
+    pub scroll: ScrollState,
     throbber_state: throbber_widgets_tui::ThrobberState,
 }
 
@@ -36,7 +33,6 @@ impl WithHeight for TopicDetailsComponent {
             .iter()
             .map(|e| e.consumer_groups.len())
             .sum::<usize>()
-            + 5
     }
 }
 
@@ -50,7 +46,22 @@ impl Component for TopicDetailsComponent {
         ComponentName::TopicDetails
     }
 
-    fn handle_key_events(&mut self, _key: KeyEvent) -> Result<Option<Action>, TuiError> {
+    fn handle_key_events(&mut self, key: KeyEvent) -> Result<Option<Action>, TuiError> {
+        match key.code {
+            KeyCode::Char('k') | KeyCode::Down => {
+                self.scroll.scroll_to_next_line();
+            }
+            KeyCode::Char('j') | KeyCode::Up => {
+                self.scroll.scroll_to_previous_line();
+            }
+            KeyCode::Char('[') => {
+                self.scroll.scroll_to_top();
+            }
+            KeyCode::Char(']') => {
+                self.scroll.scroll_to_bottom();
+            }
+            _ => (),
+        }
         Ok(None)
     }
 
@@ -200,14 +211,15 @@ impl Component for TopicDetailsComponent {
                 Line::from(""),
             ];
 
-            //let main_paragraph = Paragraph::new(text.clone())
-            //    .style(Style::default());
-
             f.render_stateful_widget(
                 table,
                 table_area.offset(Offset { x: 0, y: 5 }),
-                &mut self.state,
+                &mut self
+                    .state
+                    .clone()
+                    .with_offset((self.scroll.value() + table_area.y + 10).into()),
             );
+
             f.render_widget(
                 Paragraph::new(text)
                     .style(Style::default())
@@ -215,6 +227,8 @@ impl Component for TopicDetailsComponent {
                 rect,
             );
 
+            self.scroll.draw(f, rect, self.content_height());
+
             //
             //            let mut text: Vec<Line<'_>> = vec![];
             //            for d in &self.details {