Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizzard Shad Cleanup #46

Open
madMatchstick opened this issue Feb 20, 2025 · 2 comments
Open

Gizzard Shad Cleanup #46

madMatchstick opened this issue Feb 20, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@madMatchstick
Copy link
Collaborator

madMatchstick commented Feb 20, 2025

Bringing over Todos from PR #43

  1. Some of these ideal SI vars need to be clipped to more logical domain?
    • SI1, SI4 - water quality
    • SI5 - water depth
    • SI6 - tributaries or upper end of reservoir
      consider forcing _shape to hec-ras domain to start?

2. Clean up calculate_si_7() for error (invalid or null) catch
3. Expose each component (reproduction, water quality, food component) outside calculate_overall_suitibilty() so they can be accessed directly from the HSI class
4. Complete SI logic for non HEC-RAS H&H model inputs

@madMatchstick madMatchstick added the enhancement New feature or request label Feb 20, 2025
@dmragar
Copy link
Collaborator

dmragar commented Feb 24, 2025

  1. Domain masks (hydrologic & vegetation) for HSI and SI vars in the works in dr-in-progress #48

@madMatchstick
Copy link
Collaborator Author

  1. Error catch added in dr-in-progress #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants