Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible equation typo for bald eagle HSI #33

Open
dmragar opened this issue Feb 5, 2025 · 1 comment
Open

Possible equation typo for bald eagle HSI #33

dmragar opened this issue Feb 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@dmragar
Copy link
Collaborator

dmragar commented Feb 5, 2025

Equation for SI 5 is negative for fractional marsh cover > 0.6.
SI 6 is also likely impacted.

Function:

def si_5(x):
    return (
        0.263
        - (9.406 * np.exp(-3) * x)
        + (5.432 * np.exp(-4) * x**2)
        - (3.817 * np.exp(-6) * x**3)
    )

Image

@dmragar dmragar added the bug Something isn't working label Feb 5, 2025
@madMatchstick
Copy link
Collaborator

Seeing a similar problem with SI 6, v6_pct_cell_open_water. Values between (0,0.1) yeild negative SI values. Pertains to the middle block here:

            # condition 2 (AND)
            mask_2 = (self.v6_pct_cell_open_water > 0.0) & (
                self.v6_pct_cell_open_water <= 0.95
            )
            si_6[mask_2] = 0.985 - (0.105 * (self.v6_pct_cell_open_water[mask_2] ** -1))
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants