Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded the Laravel-Database to 5.8.* #9

Closed
abhishek70 opened this issue Jun 10, 2019 · 10 comments
Closed

Upgraded the Laravel-Database to 5.8.* #9

abhishek70 opened this issue Jun 10, 2019 · 10 comments

Comments

@abhishek70
Copy link
Contributor

Hi @Arul- ,

I was able to upgrade the Laravel-Database to 5.8.* by keeping the current folder structure same. I have tested on my end and its working as expected.

Whenever you have a chance can you please take a look at the changes : https://github.com/abhishek70/Laravel-Database/tree/Laravel-Database-5.8
and provide your feedback and suggestions regarding any changes.

If you want I can also create a pull request if that helps.

Thank you,
Abhishek

@Arul-
Copy link
Member

Arul- commented Jun 10, 2019

Can you make a pull request here, I will test and approve it

@abhishek70
Copy link
Contributor Author

Sure. Thanks

@Arul-
Copy link
Member

Arul- commented Jun 10, 2019

Fixed in #10

@Arul- Arul- closed this as completed Jun 10, 2019
@Arul-
Copy link
Member

Arul- commented Jun 10, 2019

I have also upgraded https://github.com/Luracast/Restler-Application with your contribution :)

@Arul-
Copy link
Member

Arul- commented Jun 10, 2019

Now _ide_helper.php is the only file that is out of date!

@abhishek70
Copy link
Contributor Author

Now _ide_helper.php is the only file that is out of date!

Yeah. I will take a look at generating it using https://github.com/barryvdh/laravel-ide-helper.

@Arul-
Copy link
Member

Arul- commented Jun 11, 2019

barryvdh/laravel-ide-helper#756 will help

@Arul-
Copy link
Member

Arul- commented Jun 11, 2019

I just added IDE Helper support :)

I did it as a thank you for your contribution!

I had to include queue and files otherwise it was creating so many issues so I added them under dev requirements

@abhishek70
Copy link
Contributor Author

abhishek70 commented Jun 12, 2019

Great. I will pull the changes into my branch. Thank you @Arul- .

@Arul-
Copy link
Member

Arul- commented Jun 13, 2019

As a bonus now we have the queue also available lazy loaded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants