Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trim] vkUpdateDescriptorSetTemplate path needs refinement #1419

Closed
MarkY-LunarG opened this issue Feb 7, 2024 · 2 comments · Fixed by #1502
Closed

[trim] vkUpdateDescriptorSetTemplate path needs refinement #1419

MarkY-LunarG opened this issue Feb 7, 2024 · 2 comments · Fixed by #1502
Assignees
Labels
enhancement New feature or request P1 Prevents an important capture from being replayed trimming Issue with trimming in capture or in replay

Comments

@MarkY-LunarG
Copy link
Contributor

From issue #1375, a change was added to properly track and record the accelerator data if used in a call to vkUpdateDescriptorSetTemplate. This is done for now by writing out pNext data of an accelerator structure which matches the way the other descriptor set data is currently saved for this entrypoint.

This entrypoint should properly record the tracking data without the pNext data hack to more closely reproduce the original intent of the capture.

You can reproduce this on Linux (although it happens on other platforms) using my fork of Sascha Willem's Vulkan examples. using the branch marky_move_raytrace_reflect_to_desc_templates. Building this will produce a raytracingreflectionsdesctemplates sample which can be recorded and trimmed and then replayed. Without the fix in #1375 it crashes, so when updating the source to properly fix this issue, run that sample and make sure a trimmed capture does not crash.

@MarkY-LunarG MarkY-LunarG added enhancement New feature or request trimming Issue with trimming in capture or in replay labels Feb 7, 2024
@bradgrantham-lunarg bradgrantham-lunarg added the P1 Prevents an important capture from being replayed label Mar 12, 2024
@bradgrantham-lunarg
Copy link
Contributor

@fabian-lunarg want to take a crack at this? I think it will mean reading through the existing code for tracking and descriptor set templates. Please talk with @MarkY-LunarG if there is context you think you need that is missing.

@fabian-lunarg
Copy link
Contributor

sounds good, will do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Prevents an important capture from being replayed trimming Issue with trimming in capture or in replay
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants