Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection Pixel x Scorched Guns Compatibility Issue #328

Closed
Ashen-Rook opened this issue Oct 19, 2024 · 1 comment
Closed

Protection Pixel x Scorched Guns Compatibility Issue #328

Ashen-Rook opened this issue Oct 19, 2024 · 1 comment
Labels
bug Something isn't working Forge

Comments

@Ashen-Rook
Copy link

Ashen-Rook commented Oct 19, 2024

Describe the Bug

Currently, Protection Pixel's armor plate values are being interrupted by code in Scorched Guns, giving normal brass armor a value of 4 armor for a full set, regardless of equipped plates. Armor toughness is still processed accurately, leading to strange events like in the attached image, where toughness is significantly higher than armor value. This issue IS known by both mod authors, though communication has seemingly broken down between them and it will not be fixed in the foreseeable future.

Protection Pixel's discord has found that downgrading Scorched Guns to version 0.2.1 fixes the problem, suggesting the invasive code was added after that. My suggestion would be to either remove Protection Pixel or downgrade Scorched Guns going forward to prevent people from spending time and possibly very expensive resources crafting armor that provides fewer benefits than cheaper vanilla armors due to a bug.

I would have made a pull request just suggesting this, but I can't figure out how to actually do it... e_e

Reproduction Steps

  1. create Protection Pixel armor
  2. attach armor plates in Armor Load Platform supplied with lava
  3. Armor value doesn't increase, but toughness does (when equipping brass/alloy plates. Normal armor plates provide no benefit due to not having a toughness value)
    ...

Screenshots and Videos

pp2

Crash Report or Log

No response

Operating System

Windows 10

Minecraft Version

1.20.1

Modloader

Forge

Modpack Version

confirmed for v 1.5 and up

Other Mods

I have Appleskin added, but this is a known issue specifically between Scorched Guns and Protection pixel.

@Ashen-Rook Ashen-Rook added the bug Something isn't working label Oct 19, 2024
@github-actions github-actions bot added the Forge label Oct 19, 2024
@qwek1
Copy link
Collaborator

qwek1 commented Oct 25, 2024

will see if I can do anything about this, if not then ill revert the mod

@qwek1 qwek1 closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Forge
Projects
None yet
Development

No branches or pull requests

2 participants