-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choice of scope #20
Comments
We did it to pretend to be GFM, as seen here. I'm open to changing the scope: would you like to open a PR? |
I don't really understand @hbrls arguments for using Well, personally I'd stick with what TextMate/Sublime Text use right now, Atom has adopted most of its scopes from there. If that's alright with you, I will submit a PR for Personally, I don't even use reStructuredText, but I have an Atom package that supports it. |
@idleberg It's because most themes support GFM, not rst. It's a hack. |
Correct: the goal is to get better theme highlighting. |
No, Idleberg's right. It needs to be specific: scope-names are used for a variety of things across Atom's APIs, not just styling. For instance, snippets, shortcuts/commands, autocomplete, and numerous other things can be tailored to affect certain languages only by reading their scopes. Furthermore, themes shouldn't be targeting specific languages for colours, but the scope names recommended by TextMate's authoring guidelines. If this breaks a theme's styling, it's a sign of poor authorship. |
I was wondering what made you choose
.gfm.restructuredtext
as scope name. If reStructuredText was GFM-based (GitHub Flavoured Markdown), the natural choice would be.source.gfm.restructuredtext
. Since it isn't, I'd suggest using.text.restructuredtext
instead (maybe.source.restructuredtext
). Your scope name works, it's just that it seems an odd choice.See this comparison of Sublime Text and Atom scopes
The text was updated successfully, but these errors were encountered: