Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FragDecoder GetParity and SetParity uint8_t overflow #785

Closed
KaDw opened this issue Sep 10, 2019 · 2 comments
Closed

FragDecoder GetParity and SetParity uint8_t overflow #785

KaDw opened this issue Sep 10, 2019 · 2 comments
Labels
bug

Comments

@KaDw
Copy link
Contributor

KaDw commented Sep 10, 2019 •
edited
Loading

GetParity and SetParity functions are using uin8_t index as argument but it can overflow if FragNb is >255 (which can happen). If that is the case, whole LDPC algorithm gets corrupted and it is unable to repair any frames. Solution is to change GetParity and SetParity argument uint8_t index to uint16_t index.
@mluis1
Copy link
Contributor

mluis1 commented Sep 10, 2019

Thanks for the finding.

Would it be possible for you to propose a pull request with the fixed types?

@mluis1 mluis1 added the bug label Sep 10, 2019
@KaDw
Copy link
Contributor Author

KaDw commented Sep 10, 2019

sure, here it is #786

@KaDw KaDw mentioned this issue Sep 10, 2019
Merged
@mluis1 mluis1 closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mluis1 @KaDw