Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #6

Closed
sindresorhus opened this issue Sep 20, 2018 · 1 comment
Closed

Feedback #6

sindresorhus opened this issue Sep 20, 2018 · 1 comment

Comments

@sindresorhus
Copy link

  • context.setProgress('Uploading…'); should be placed above await Fanfou.upload(token, filePath);. Don't show status until you're actually doing the thing you describe.
  • You don't have to try/catch here. We catch any error from plugins and display a notification.
  • default: 'Your consumer key', is incorrect. That is not a default value. You should instead use the description key for this: description: 'Your consumer key',.
  • The useNofanConfig config needs a description key with a description of what it actually that. It's not clear from the title.
@karaggeorge karaggeorge mentioned this issue Sep 20, 2018
@LitoMore
Copy link
Owner

@sindresorhus Thank you Sindre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants