Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] After update Dashy is not authenticating and guest mode is always on #1126

Closed
5 tasks done
saint11 opened this issue Mar 1, 2023 · 17 comments
Closed
5 tasks done
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 📌 Keep Open [ISSUE][PR] Prevent auto-closing 🛩️ Released 2.1.2

Comments

@saint11
Copy link

saint11 commented Mar 1, 2023

Environment

Self-Hosted (Docker)

System

Docker 20.10.18

Version

2.1.1

Describe the problem

When opening my dashboard I noticed that I wasn't logged in (I couldn't change anything) but I could see my links, even if I tried manually setting enableGuestAccess: false on config.yml.

I tried hideForGuests: true in a couple sessions too, that cause the whole browser screen to disappear.

Rolling back to 2.1.0 fixed the problem.

Additional info

No response

Please tick the boxes

@saint11 saint11 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Mar 1, 2023
@xyzeratul
Copy link

I have encounter the same bug as well, running 2.1.1 on docker, no matter how I edit the config, the guest access is always on

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 1, 2023
@pabloalcantara
Copy link

Same bug on 2.1.1, revert to 2.1.0 and authentications works again

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 3, 2023
@psychic69
Copy link

psychic69 commented Mar 12, 2023

The issue is that if a user is not logged on in 2.1.1 it will allow one to go to the base / URL and it won't enforce /login like 2.0.1. I reverted for now this is an unreliable auth method in the meantime. I also noticed in 2.1.1 it will pass the yaml checker but if the enableGuestAccess: false is not in the yaml auth will not work. The documentation says in appconfig.auth this is optional and defaults to false, but if this is not in 2.1.1 it will not auth at all, among the bug.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Mar 12, 2023
@liquidthex
Copy link

I am experiencing this, as well.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 2, 2023
@MadDirtMonkey
Copy link

Same problem here, working fine when I roll back to 2.1.0

@stevenmccall
Copy link

I had the same issue updating to 2.1.1, but rolling back to 2.1.0 did not resolve the issue. I had to roll back to 2.0.0 to get the login working again. It had been a while since the docker was updated, maybe there was some intermediate change to the config that was not checked in 2.1.0 that leads to a similar issue as this 2.1.1 bug.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 4, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented May 5, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label May 5, 2023
@CaptainSanders
Copy link

Any update on this?

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels May 5, 2023
@mfnalex
Copy link

mfnalex commented Jun 21, 2023

I got a similar issue on 2.1.1 - adding the appConfig.auth section with one user and setting enableGuestAccess to false doesn't do anything - I don't get any login screen, manually going to /login redirects to the dashboard, and all links are visible, even those that are hidden for guests.

@mfnalex
Copy link

mfnalex commented Jun 21, 2023

I just noticed that the whole authentication thing seems to work when setting enableGuestAccess to true, but not when it's set to false

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 22, 2023
@zell-mbc
Copy link

Unfortunately not for me. All versions higher than v2.1.0 break the login for me, no matter what enableGuestAccess is set to.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 26, 2023
@sr-as2
Copy link

sr-as2 commented Jun 28, 2023

Have the same problem!
Hope it will be be resolved soon!

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 29, 2023
@Jefffish09
Copy link

Same issue.
Hope to release a new version to fix it.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jul 23, 2023
@Lissy93 Lissy93 added the 📌 Keep Open [ISSUE][PR] Prevent auto-closing label Jul 23, 2023
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jul 24, 2023
@TheRealGramdalf
Copy link

I believe I found the issue - see #1290 (comment) for a full writeup.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 10, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Dashy V3 Jan 10, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 28, 2024
@CrazyWolf13
Copy link
Collaborator

Hi
This problems seems to be related to dashy not automatically rebuilding on changes, see #1479 and #1290 (comment)
A new release has just been published, which should fix this issue, so please upgrade to the latest version.
If this is not the case just respond back to this ticket and I'll reopen this issue.
Thanks and have a nice day.

@github-project-automation github-project-automation bot moved this from Awaiting Triage to Done in Dashy V3 Mar 3, 2024
@CrazyWolf13 CrazyWolf13 added ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🛩️ Released 2.1.2 labels Mar 3, 2024
@zell-mbc
Copy link

zell-mbc commented Mar 3, 2024

Docker not yet updated?
% sudo docker compose up -d && sudo docker compose logs -f [+] Running 1/1 ✘ dashboard Error 1.8s Error response from daemon: manifest for lissy93/dashy:2.1.2 not found: manifest unknown: manifest unknown

I tried latest as well but that still gives me 2.1.1

@CrazyWolf13
Copy link
Collaborator

CrazyWolf13 commented Mar 3, 2024

Docker not yet updated? % sudo docker compose up -d && sudo docker compose logs -f [+] Running 1/1 ✘ dashboard Error 1.8s Error response from daemon: manifest for lissy93/dashy:2.1.2 not found: manifest unknown: manifest unknown

I tried latest as well but that still gives me 2.1.1

Please give us a moment, see here:
#1484 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 📌 Keep Open [ISSUE][PR] Prevent auto-closing 🛩️ Released 2.1.2
Projects
Status: Done
Development

No branches or pull requests