-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force hook standalone tests to single device #20491
Merged
lantiga
merged 3 commits into
master
from
luca/force-some-standalone-tests-to-single-device
Dec 11, 2024
Merged
Force hook standalone tests to single device #20491
lantiga
merged 3 commits into
master
from
luca/force-some-standalone-tests-to-single-device
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20491 +/- ##
=========================================
- Coverage 88% 79% -9%
=========================================
Files 267 264 -3
Lines 23382 23327 -55
=========================================
- Hits 20479 18364 -2115
- Misses 2903 4963 +2060 |
Does the fallback to single device defeat the purpose of the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A few failures in standalone tests are due to the fact that hook tests cannot be run on multiple devices (at least the way they are written), since
prepare_data
only runs on rank 0. This was the cause of rather obscure failures.Since hook tests are verifying the sanity of the sequence of hooks, it's ok to limit to single device.
📚 Documentation preview 📚: https://pytorch-lightning--20491.org.readthedocs.build/en/20491/