Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ: Overvoltage and undervoltage alert debouncing calculation wrong if sampling frequency != 1kHz #109

Open
martinjaeger opened this issue Oct 26, 2020 · 2 comments
Labels

Comments

@martinjaeger
Copy link
Member

The debouncing depends on the sampling frequency being 1 kHz, so one call is equivalent to 1 millisecond. This should be fixed to work properly in STM32G4 based charge controllers which currently run the ADC at much higher sampling rate.

@JordanSilverman
Copy link
Contributor

Do you think this was the issue that caused the overvoltage protection to fail in your controller?

@martinjaeger
Copy link
Member Author

No, don't think so, as it was only configured for battery overvoltage so far. But I realized this issue while implementing the protection for the high-side aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants