Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data chunking #2

Open
TRPB opened this issue Sep 26, 2018 · 0 comments
Open

Data chunking #2

TRPB opened this issue Sep 26, 2018 · 0 comments
Milestone

Comments

@TRPB
Copy link
Member

TRPB commented Sep 26, 2018

The biggest speed bottleneck and breaking issue is the message queue size. At the moment it's 50 kilobytes. Not all messages (read: web pages) are 50 kb. There are performance advantages to be had by lowering it and things just truncate if you try to display a larger page.

This can be fixed by chunking the messages. I'll need to do some testing for optimal chunk size but instead of sending one large message, a message large enough for most cases with the ability to send additional messages is the solution here.

It would be possible to do it always with two messages from the server to the client: 1. here's the size of the data to expect in message 2. 2. here's the data of the size you're expecting but this will give an unnecessary overhead if it could be done in a single message as it is now.

@TRPB TRPB added this to the 0.9 milestone Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant