Skip to content
This repository has been archived by the owner on Feb 14, 2019. It is now read-only.

Always use forward slashes, even on Windows? #22

Closed
belluzj opened this issue Oct 3, 2017 · 2 comments
Closed

Always use forward slashes, even on Windows? #22

belluzj opened this issue Oct 3, 2017 · 2 comments

Comments

@belluzj
Copy link
Contributor

belluzj commented Oct 3, 2017

Hello,

I'm using MutatotMath on Windows and the line 217 of document.py uses os.path, so it always replaces forward slashes with backward slashes on Windows. There might be an issue if someone generates a design space document on windows and tries to use it on linux/mac, so maybe the spec could be updated to say that the filename attribute should always use forward slashes; by adding a bullet point to this list:

https://github.com/LettError/designSpaceDocument/blob/master/README.md#paths-and-filenames

What do you think?

@moyogo

@anthrotype
Copy link
Contributor

I agree it's better to normalize this and always use forward slashes for path names in the designspace.
I think relative paths with forward slashes should work on Windows as well.

@belluzj
Copy link
Contributor Author

belluzj commented Oct 3, 2017

OK, I will open a pull request here and in MutatorMath.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants