Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public API to generate a single instance #98

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Add a public API to generate a single instance #98

merged 1 commit into from
Nov 4, 2017

Conversation

khaledhosny
Copy link
Contributor

Needed to allow easy parallel build for fonts with large number of
instances.

Background: googlefonts/fontmake#367 (comment)

Needed to allow easy parallel build for fonts with large number of
instances.

Background: googlefonts/fontmake#367 (comment)
@behdad
Copy link

behdad commented Nov 4, 2017

Good good. Thanks.

@coveralls
Copy link

coveralls commented Nov 4, 2017

Coverage Status

Coverage decreased (-0.3%) to 88.142% when pulling 28dcec4 on khaledhosny:readinstance into 3989f8a on LettError:master.

@anthrotype
Copy link
Collaborator

thanks Khaled!
github says you branch has conflicts with the base branch.

@anthrotype
Copy link
Collaborator

I misread, it has "no conflicts", sorry!

@anthrotype anthrotype merged commit 67e92d6 into LettError:master Nov 4, 2017
@khaledhosny khaledhosny deleted the readinstance branch November 4, 2017 16:38
khaledhosny added a commit to aliftype/mada that referenced this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants