This addresses a problem caused by files in which a source element ha… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no name attribute. Mutator uses the value of the name attribute to store some data and retrieve it later. This adds a temporary simple unique name.
anthrotype
reviewed
Mar 28, 2017
Lib/mutatorMath/ufo/document.py
Outdated
| @@ -502,12 +502,19 @@ def readSources(self): | |||
| </source> | |||
|
|
|||
| """ | |||
| sourceCount = 0 | |||
| for sourceElement in self.root.findall(".sources/source"): | |||
There was a problem hiding this comment.
you could also do this instead:
-sourceCount = 0
-for sourceElement in self.root.findall(".sources/source"):
- sourceCount+=1
+for sourceCount, sourceElement in enumerate(self.root.findall(".sources/source")):
anthrotype
reviewed
Mar 28, 2017
Lib/mutatorMath/ufo/document.py
Outdated
| # (some authoring tools do not need them) | ||
| # then we should make a temporary one | ||
| sourceName = "temp_master.%d"%(sourceCount) | ||
| print("created temp source name", sourceName) |
There was a problem hiding this comment.
why not use self.logger instead of print here?
anthrotype
approved these changes
Mar 28, 2017
|
Thank you! |
Remove print.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s no name attribute. Mutator uses the value of the name attribute to store some data and retrieve it later. This adds a temporary simple unique name.