You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are all properties now intended to be readonly since v0.6.1? Error "TypeError: Cannot assign to read only property 'OtherProperty' of object '#<Object>'" after the update
#689
Closed
ceisele-r opened this issue
Jul 26, 2023
· 3 comments
After updating from v0.6.0 to v0.6.1, we are facing issues like the following:
TypeError: Cannot assign to read only property 'OtherProperty' of object '#<Object>'
The issue occurs when doing something like this:
constparser=newParser();constdata=awaitparser.parseStringPromise(fileXml);data.SomeProperty.OtherProperty=["some"];// Error happens here
Is it intended that all properties are now readonly (/is this the result of the recent CVE fixes)?
I am wondering because when looking at the diff from v0.6.0 to v0.6.1, here it seems that properties should still be defined writable.
The text was updated successfully, but these errors were encountered:
It is definitely not meant to be like this (and that would be a breaking change), so I am indeed surprised that they are read-only. As you point out this is a fix for the recent CVE that does not rely on filtering names so I am rather surprised it breaks in such a way. Need to investigate what is going on.
I figured it out, the writable attribute was mistyped. In my tests things would just silently fail instead of showing an error but they would fail indeed. I've released 0.6.2 fixing this.
After updating from
v0.6.0
tov0.6.1
, we are facing issues like the following:The issue occurs when doing something like this:
Is it intended that all properties are now readonly (/is this the result of the recent CVE fixes)?
I am wondering because when looking at the diff from
v0.6.0
tov0.6.1
, here it seems that properties should still be defined writable.The text was updated successfully, but these errors were encountered: