From af89d229033d76c09b8858e140fe21f61577b336 Mon Sep 17 00:00:00 2001 From: Tushar4432 <139869581+Tushar4432@users.noreply.github.com> Date: Mon, 16 Dec 2024 23:40:02 +0530 Subject: [PATCH] Removed deprecated code from Alibaba provider package (#44576) * issue 44559 removed depricated code from alibaba provider * Apply suggestions from code review Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> --- .../src/airflow/providers/alibaba/CHANGELOG.rst | 14 ++++++++++++++ .../alibaba/cloud/operators/analyticdb_spark.py | 9 +-------- .../alibaba/cloud/sensors/analyticdb_spark.py | 8 -------- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/providers/src/airflow/providers/alibaba/CHANGELOG.rst b/providers/src/airflow/providers/alibaba/CHANGELOG.rst index 6926f10a86362..3dd8a237f58c2 100644 --- a/providers/src/airflow/providers/alibaba/CHANGELOG.rst +++ b/providers/src/airflow/providers/alibaba/CHANGELOG.rst @@ -26,6 +26,20 @@ Changelog --------- + + +.. warning:: + All deprecated classes, parameters and features have been removed from the alibaba provider package. + The following breaking changes were introduced: + + * Operators + * Remove ``get_hook`` method from ``AnalyticDBSparkBaseOperator``. Use ``self.hook`` instead. + + * sensors + * Remove ``get_hook`` method from ``AnalyticDBSparkSensor``. Use ``self.hook`` instead. + + + 2.9.1 ..... diff --git a/providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py b/providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py index 324b715ddff33..3cf414230f519 100644 --- a/providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py +++ b/providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py @@ -22,9 +22,7 @@ from functools import cached_property from typing import TYPE_CHECKING, Any -from deprecated.classic import deprecated - -from airflow.exceptions import AirflowException, AirflowProviderDeprecationWarning +from airflow.exceptions import AirflowException from airflow.models import BaseOperator from airflow.providers.alibaba.cloud.hooks.analyticdb_spark import AnalyticDBSparkHook, AppState @@ -56,11 +54,6 @@ def hook(self) -> AnalyticDBSparkHook: """Get valid hook.""" return AnalyticDBSparkHook(adb_spark_conn_id=self._adb_spark_conn_id, region=self._region) - @deprecated(reason="use `hook` property instead.", category=AirflowProviderDeprecationWarning) - def get_hook(self) -> AnalyticDBSparkHook: - """Get valid hook.""" - return self.hook - def execute(self, context: Context) -> Any: ... def monitor_application(self): diff --git a/providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py b/providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py index afbbeef4d9275..705c1fddab7f7 100644 --- a/providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py +++ b/providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py @@ -21,9 +21,6 @@ from functools import cached_property from typing import TYPE_CHECKING, Any -from deprecated.classic import deprecated - -from airflow.exceptions import AirflowProviderDeprecationWarning from airflow.providers.alibaba.cloud.hooks.analyticdb_spark import AnalyticDBSparkHook, AppState from airflow.sensors.base import BaseSensorOperator @@ -60,11 +57,6 @@ def hook(self) -> AnalyticDBSparkHook: """Get valid hook.""" return AnalyticDBSparkHook(adb_spark_conn_id=self._adb_spark_conn_id, region=self._region) - @deprecated(reason="use `hook` property instead.", category=AirflowProviderDeprecationWarning) - def get_hook(self) -> AnalyticDBSparkHook: - """Get valid hook.""" - return self.hook - def poke(self, context: Context) -> bool: app_id = self.app_id