Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@material-ui/core@4 support #212

Open
neo-andrew-moss opened this issue Dec 31, 2022 · 0 comments
Open

@material-ui/core@4 support #212

neo-andrew-moss opened this issue Dec 31, 2022 · 0 comments

Comments

@neo-andrew-moss
Copy link

Hi @Learus!

First off, thanks for a great carousel implementation. Carousels are always a bit of a nightmare, but this one is amazing.

Anyway, I am using react-material-ui-carousel@2 as my app does not yet support "@mui/material". However, the peerDependencies of react-material-ui-carousel@2 are pointing towards "@material-ui/core": "^4.11.3", which doesn't work for me as I am using "@material-ui/core": "4.11.2",. Resultingly, I have to install this library with --force or --legacy-peer-deps, which is sub-optimal.

What do you think about another v2 release with slightly more relaxed peers? Im not sure what this would look like semver wise but I created a good implementation that could be used for this.

I forked this lib and created react-material-ui-carousel-alt, which is a refactor of react-material-ui-carousel@2 with all the updates of react-material-ui-carousel@3 but with @material-ui/core@4 instead of "@mui/material". The peerDependencies of react-material-ui-carousel-alt are a little more flexible.

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant