Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Styling] Get rid of redundant ternary operators #111

Closed
dalechyn opened this issue Sep 6, 2021 · 1 comment
Closed

[Code Styling] Get rid of redundant ternary operators #111

dalechyn opened this issue Sep 6, 2021 · 1 comment

Comments

@dalechyn
Copy link

dalechyn commented Sep 6, 2021

react-material-ui-carousel/src/components/Carousel.js

Lines 363 to 364 in 93ecb0f

display={index === this.state.displayed ? true : false}
active={index === this.state.active ? true : false}

react-material-ui-carousel/src/components/Carousel.js

Line 331 in 93ecb0f

return reverseEdgeAnimationDirection ? true : false;

react-material-ui-carousel/src/components/Carousel.js

Line 326 in 93ecb0f

return reverseEdgeAnimationDirection ? false : true;

@Learus
Copy link
Owner

Learus commented Sep 22, 2021

Fixed in v2.3.5.

@Learus Learus closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Learus @dalechyn