From ec88998eb8456295d5360964876b192d01002ec3 Mon Sep 17 00:00:00 2001
From: Christoph <siedlerkiller@gmail.com>
Date: Fri, 29 Jan 2021 22:11:29 +0100
Subject: [PATCH] Fix File Filter and some layout issues (#7385)

* Fix File Filter and some layout issues

Fixes part of #7383

* better min width

* Any file instead of all

* remove style class

* l10n

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
---
 src/main/java/org/jabref/gui/Base.css         |  2 +-
 .../externalfiles/FileExtensionViewModel.java |  2 +-
 .../externalfiles/UnlinkedFilesCrawler.java   |  2 +-
 .../externalfiles/UnlinkedFilesDialog.fxml    | 14 ++--
 .../externalfiles/UnlinkedPDFFileFilter.java  |  8 +-
 .../java/org/jabref/logic/util/FileType.java  |  2 +
 .../jabref/logic/util/StandardFileType.java   | 78 ++++++++++---------
 .../jabref/logic/util/UnknownFileType.java    |  5 ++
 .../logic/util/io/DatabaseFileLookup.java     |  6 +-
 src/main/resources/l10n/JabRef_en.properties  |  2 +-
 10 files changed, 70 insertions(+), 51 deletions(-)

diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css
index bf6f8fb5612..ffe7cd3f04f 100644
--- a/src/main/java/org/jabref/gui/Base.css
+++ b/src/main/java/org/jabref/gui/Base.css
@@ -1217,6 +1217,6 @@ TextFlow * {
 
 }
 
-.mainTable-header{
+.mainTable-header {
     -fx-fill: -fx-mid-text-color;
 }
diff --git a/src/main/java/org/jabref/gui/externalfiles/FileExtensionViewModel.java b/src/main/java/org/jabref/gui/externalfiles/FileExtensionViewModel.java
index f1f51862c30..121517bf5bc 100644
--- a/src/main/java/org/jabref/gui/externalfiles/FileExtensionViewModel.java
+++ b/src/main/java/org/jabref/gui/externalfiles/FileExtensionViewModel.java
@@ -19,7 +19,7 @@ public class FileExtensionViewModel {
     private final ExternalFileTypes externalFileTypes;
 
     FileExtensionViewModel(FileType fileType, ExternalFileTypes externalFileTypes) {
-        this.description = Localization.lang("%0 file", fileType.toString());
+        this.description = Localization.lang("%0 file", fileType.getName());
         this.extensions = fileType.getExtensionsWithDot();
         this.externalFileTypes = externalFileTypes;
     }
diff --git a/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java b/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java
index 60d89246e1b..4b29a57204f 100644
--- a/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java
+++ b/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java
@@ -74,7 +74,7 @@ private FileNodeViewModel searchDirectory(Path directory, UnlinkedPDFFileFilter
         Map<Boolean, List<Path>> fileListPartition;
 
         try (Stream<Path> filesStream = StreamSupport.stream(Files.newDirectoryStream(directory, fileFilter).spliterator(), false)) {
-            fileListPartition = filesStream.collect(Collectors.partitioningBy(path -> path.toFile().isDirectory()));
+            fileListPartition = filesStream.collect(Collectors.partitioningBy(Files::isDirectory));
         } catch (IOException e) {
             LOGGER.error(String.format("%s while searching files: %s", e.getClass().getName(), e.getMessage()));
             return parent;
diff --git a/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialog.fxml b/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialog.fxml
index 0d3246da39d..bea10fcc9c3 100644
--- a/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialog.fxml
+++ b/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialog.fxml
@@ -34,14 +34,14 @@
                 <ColumnConstraints hgrow="SOMETIMES"/>
             </columnConstraints>
             <rowConstraints>
-                <RowConstraints minHeight="10.0" vgrow="SOMETIMES"/>
-                <RowConstraints minHeight="10.0" vgrow="SOMETIMES"/>
+                <RowConstraints minHeight="20.0" vgrow="SOMETIMES"/>
+                <RowConstraints minHeight="20.0" vgrow="SOMETIMES"/>
             </rowConstraints>
                 <Label text="%Start directory:" GridPane.columnIndex="0" GridPane.rowIndex="0"/>
                 <TextField fx:id="directoryPathField" GridPane.columnIndex="1" GridPane.rowIndex="0"/>
                 <Button onAction="#browseFileDirectory" styleClass="icon-button,narrow"
                         GridPane.columnIndex="2" GridPane.rowIndex="0"
-                        prefHeight="20.0" prefWidth="20.0">
+                        minWidth="20.0" minHeight="20.0" prefHeight="20.0" prefWidth="20.0">
                     <graphic>
                         <JabRefIconView glyph="OPEN"/>
                     </graphic>
@@ -50,9 +50,9 @@
                     </tooltip>
                 </Button>
 
-                <Label text="%File extension:" GridPane.columnIndex="0" GridPane.rowIndex="1"/>
+                <Label text="%File type:" GridPane.columnIndex="0" GridPane.rowIndex="1"/>
                 <ComboBox fx:id="fileTypeCombo" maxWidth="Infinity" GridPane.columnIndex="1" GridPane.rowIndex="1"/>
-                <Button fx:id="scanButton" onAction="#scanFiles" text="%Scan directory"
+                <Button fx:id="scanButton" onAction="#scanFiles" text="%Search"
                         GridPane.columnIndex="2" GridPane.rowIndex="1">
                     <tooltip>
                         <Tooltip text="%Searches the selected directory for unlinked files."/>
@@ -71,11 +71,11 @@
                             <TableView fx:id="importResultTable">
                                 <columns>
                                     <TableColumn fx:id="colStatus" prefWidth="100.0" text="%Status"/>
-                                    <TableColumn fx:id="colMessage" prefWidth="300.0" text="%Message"/>
                                     <TableColumn fx:id="colFile" prefWidth="500.0" text="%File"/>
+                                    <TableColumn fx:id="colMessage" prefWidth="300.0" text="%Message"/>
                                 </columns>
                                 <columnResizePolicy>
-                                    <TableView fx:constant="CONSTRAINED_RESIZE_POLICY"/>
+                                    <TableView fx:constant="UNCONSTRAINED_RESIZE_POLICY"/>
                                 </columnResizePolicy>
                             </TableView>
                         </TitledPane>
diff --git a/src/main/java/org/jabref/gui/externalfiles/UnlinkedPDFFileFilter.java b/src/main/java/org/jabref/gui/externalfiles/UnlinkedPDFFileFilter.java
index 1d235d7fbf3..0cdb7263263 100644
--- a/src/main/java/org/jabref/gui/externalfiles/UnlinkedPDFFileFilter.java
+++ b/src/main/java/org/jabref/gui/externalfiles/UnlinkedPDFFileFilter.java
@@ -4,6 +4,7 @@
 import java.io.IOException;
 import java.nio.file.DirectoryStream;
 import java.nio.file.DirectoryStream.Filter;
+import java.nio.file.Files;
 import java.nio.file.Path;
 
 import org.jabref.logic.util.io.DatabaseFileLookup;
@@ -31,6 +32,11 @@ public UnlinkedPDFFileFilter(DirectoryStream.Filter<Path> fileFilter, BibDatabas
 
     @Override
     public boolean accept(Path pathname) throws IOException {
-        return fileFilter.accept(pathname) && !lookup.lookupDatabase(pathname.toFile());
+
+        if (Files.isDirectory(pathname)) {
+            return true;
+        } else {
+            return fileFilter.accept(pathname) && !lookup.lookupDatabase(pathname);
+        }
     }
 }
diff --git a/src/main/java/org/jabref/logic/util/FileType.java b/src/main/java/org/jabref/logic/util/FileType.java
index e39d5ba90fb..7e4ba2199ec 100644
--- a/src/main/java/org/jabref/logic/util/FileType.java
+++ b/src/main/java/org/jabref/logic/util/FileType.java
@@ -15,4 +15,6 @@ default List<String> getExtensionsWithDot() {
     }
 
     List<String> getExtensions();
+
+    String getName();
 }
diff --git a/src/main/java/org/jabref/logic/util/StandardFileType.java b/src/main/java/org/jabref/logic/util/StandardFileType.java
index 3ad3d1d7e3b..7a9d5d08c48 100644
--- a/src/main/java/org/jabref/logic/util/StandardFileType.java
+++ b/src/main/java/org/jabref/logic/util/StandardFileType.java
@@ -10,45 +10,46 @@
  */
 public enum StandardFileType implements FileType {
 
-    BIBTEXML("bibx", "xml"),
-    ENDNOTE("ref", "enw"),
-    ISI("isi", "txt"),
-    MEDLINE("nbib", "xml"),
-    MEDLINE_PLAIN("nbib", "txt"),
-    PUBMED("fcgi"),
-    SILVER_PLATTER("dat", "txt"),
-
-    AUX("aux"),
-    BIBTEX_DB("bib"),
-    CITATION_STYLE("csl"),
-    CLASS("class"),
-    CSV("csv"),
-    HTML("html", "htm"),
-    JAR("jar"),
-    JAVA_KEYSTORE("jks"),
-    JSTYLE("jstyle"),
-    LAYOUT("layout"),
-    ODS("ods"),
-    PDF("pdf"),
-    RIS("ris"),
-    TERMS("terms"),
-    TXT("txt"),
-    RDF("rdf"),
-    RTF("rtf"),
-    SXC("sxc"),
-    TEX("tex"),
-    XML("xml"),
-    JSON("json"),
-    XMP("xmp"),
-    ZIP("zip"),
-    CSS("css"),
-    YAML("yaml"),
-    ANY_FILE("*");
+    BIBTEXML("BibTeXML", "bibx", "xml"),
+    ENDNOTE("Endnote", "ref", "enw"),
+    ISI("Isi", "isi", "txt"),
+    MEDLINE("Medline", "nbib", "xml"),
+    MEDLINE_PLAIN("Medline Plain", "nbib", "txt"),
+    PUBMED("Pubmed", "fcgi"),
+    SILVER_PLATTER("SilverPlatter", "dat", "txt"),
+    AUX("Aux file", "aux"),
+    BIBTEX_DB("Bibtex library", "bib"),
+    CITATION_STYLE("Citation Style", "csl"),
+    CLASS("Class file", "class"),
+    CSV("CSV", "csv"),
+    HTML("HTML", "html", "htm"),
+    JAR("JAR", "jar"),
+    JAVA_KEYSTORE("Java Keystore", "jks"),
+    JSTYLE("LibreOffice layout style", "jstyle"),
+    LAYOUT("Custom Exporter format", "layout"),
+    ODS("OpenOffice Calc", "ods"),
+    PDF("PDF", "pdf"),
+    RIS("RIS", "ris"),
+    TERMS("Protected terms", "terms"),
+    TXT("Plain Text", "txt"),
+    RDF("RDF", "rdf"),
+    RTF("RTF", "rtf"),
+    SXC("Open Office Calc 1.x", "sxc"),
+    TEX("LaTeX", "tex"),
+    XML("XML", "xml"),
+    JSON("JSON", "json"),
+    XMP("XMP", "xmp"),
+    ZIP("Zip Archive", "zip"),
+    CSS("CSS Styleshet", "css"),
+    YAML("YAML Markup", "yaml"),
+    ANY_FILE("Any", "*");
 
     private final List<String> extensions;
+    private final String name;
 
-    StandardFileType(String... extensions) {
+    StandardFileType(String name, String... extensions) {
         this.extensions = Arrays.asList(extensions);
+        this.name = name;
     }
 
     @Override
@@ -56,12 +57,17 @@ public List<String> getExtensions() {
         return extensions;
     }
 
+    @Override
+    public String getName() {
+        return this.name;
+    }
+
     public static FileType fromExtensions(String... extensions) {
         var exts = Arrays.asList(extensions);
 
         return OptionalUtil.orElse(Arrays.stream(StandardFileType.values())
                                          .filter(field -> field.getExtensions().stream().anyMatch(elem -> exts.contains(elem)))
                                          .findAny(),
-                new UnknownFileType(extensions));
+                                   new UnknownFileType(extensions));
     }
 }
diff --git a/src/main/java/org/jabref/logic/util/UnknownFileType.java b/src/main/java/org/jabref/logic/util/UnknownFileType.java
index e057caa3974..a2b7453d261 100644
--- a/src/main/java/org/jabref/logic/util/UnknownFileType.java
+++ b/src/main/java/org/jabref/logic/util/UnknownFileType.java
@@ -43,4 +43,9 @@ public boolean equals(Object o) {
     public int hashCode() {
         return Objects.hash(extensions);
     }
+
+    @Override
+    public String getName() {
+        return "Unknown File Type" + extensions.toString();
+    }
 }
diff --git a/src/main/java/org/jabref/logic/util/io/DatabaseFileLookup.java b/src/main/java/org/jabref/logic/util/io/DatabaseFileLookup.java
index 839a6432a71..11c076820ce 100644
--- a/src/main/java/org/jabref/logic/util/io/DatabaseFileLookup.java
+++ b/src/main/java/org/jabref/logic/util/io/DatabaseFileLookup.java
@@ -48,12 +48,12 @@ public DatabaseFileLookup(BibDatabaseContext databaseContext, FilePreferences fi
      * <br>
      * For the matching, the absolute file paths will be used.
      *
-     * @param file A {@link File} Object.
+     * @param pathname A {@link File} Object.
      * @return <code>true</code>, if the file Object is stored in at least one
      * entry in the database, otherwise <code>false</code>.
      */
-    public boolean lookupDatabase(File file) {
-        return fileCache.contains(file.toPath());
+    public boolean lookupDatabase(Path pathname) {
+        return fileCache.contains(pathname);
     }
 
     private List<Path> parseFileField(BibEntry entry) {
diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
index 8cfb645b5fb..e343995123a 100644
--- a/src/main/resources/l10n/JabRef_en.properties
+++ b/src/main/resources/l10n/JabRef_en.properties
@@ -1107,10 +1107,10 @@ Unable\ to\ clear\ preferences.=Unable to clear preferences.
 Unselect\ all=Unselect all
 Expand\ all=Expand all
 Collapse\ all=Collapse all
-Scan\ directory=Scan directory
 Searches\ the\ selected\ directory\ for\ unlinked\ files.=Searches the selected directory for unlinked files.
 Starts\ the\ import\ of\ BibTeX\ entries.=Starts the import of BibTeX entries.
 Start\ directory\:=Start directory:
+File\ type\:=File type:
 Currently\ unlinked\ files=Currently unlinked files
 Import\ result=Import result
 Searching\ file\ system...=Searching file system...