Skip to content
This repository has been archived by the owner on Feb 7, 2021. It is now read-only.

Travis Build Failing #28

Closed
matwright opened this issue Jul 17, 2020 · 3 comments
Closed

Travis Build Failing #28

matwright opened this issue Jul 17, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@matwright
Copy link
Member

There are a number of notices and several fatal errors in the Test suite preventing the automated builds from suceeding.

PHP Fatal error: Declaration of LmcUserTest\Authentication\Adapter\TestAsset\AbstractAdapterExtension::authenticate(Laminas\EventManager\EventInterface $e) must be compatible with LmcUser\Authentication\Adapter\ChainableAdapter::authenticate(LmcUser\Authentication\Adapter\AdapterChainEvent $e) in /home/travis/build/Laminas-Commons/LmcUser/tests/LmcUserTest/Authentication/Adapter/TestAsset/AbstractAdapterExtension.php on line 8

@matwright matwright self-assigned this Jul 17, 2020
@matwright matwright added the bug Something isn't working label Jul 17, 2020
@visto9259
Copy link
Contributor

We should probably remove testing with older versions of PHP and HHVM which are no longer supported.
And also bump up phpunit to a more recent supported version. That's not a simple task since there are BC when migrating to more recent versions of phpunit.

@matwright
Copy link
Member Author

I have completed this work. I've removed <7.3 as those versions are not supported in at least one of the Laminas components used in LmcUser or it's dependencies.

I've updated phpunit to the latest version (a jump from v3 to v9!) and corrected/updated many tests that were using since-removed phpunity methods.

My PR is passing Travis now, too.

#30

If you'd like to review @visto9259 we can merge into the 3.1.x branch.

At that point I can look at merging the other PR into the branch and a new release asap.

@matwright
Copy link
Member Author

reviewed by @visto9259 and merged in 3.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants